Skip to content

Set data field by expression#1683

Merged
ivarne merged 52 commits into
mainfrom
feature/set-data-field-by-expression
Jun 15, 2026
Merged

Set data field by expression#1683
ivarne merged 52 commits into
mainfrom
feature/set-data-field-by-expression

Fixed unit tests

9bd887e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 16, 2026 in 1m 2s

Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 10 in src/Altinn.App.Core/Helpers/DataModel/DataModelWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQuihgA_Kbzevoda&open=AZy-iQuihgA_Kbzevoda&pullRequest=1683

Check warning on line 219 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevoco&open=AZy-iQnyhgA_Kbzevoco&pullRequest=1683

Check failure on line 470 in src/Altinn.App.Core/Implementation/AppResourcesSI.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not construct the path from user-controlled data.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQvqhgA_Kbzevodg&open=AZy-iQvqhgA_Kbzevodg&pullRequest=1683

Check warning on line 298 in src/Altinn.App.Core/Implementation/AppResourcesSI.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not construct the path from user-controlled data.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQvqhgA_Kbzevodl&open=AZy-iQvqhgA_Kbzevodl&pullRequest=1683

Check warning on line 29 in src/Altinn.App.Core/Features/DataLists/InstanceDataListsFactory.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loops should be simplified using the "Where" LINQ method

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQsxhgA_Kbzevoc5&open=AZy-iQsxhgA_Kbzevoc5&pullRequest=1683

Check warning on line 244 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocq&open=AZy-iQnyhgA_Kbzevocq&pullRequest=1683

Check warning on line 172 in src/Altinn.App.Core/Features/DataProcessing/DataFieldValueCalculator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Collection initialization can be simplified

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQs9hgA_KbzevodP&open=AZy-iQs9hgA_KbzevodP&pullRequest=1683

Check warning on line 19 in src/Altinn.App.Core/Internal/Expressions/ExpressionEvaluator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQl6hgA_Kbzevoch&open=AZy-iQl6hgA_Kbzevoch&pullRequest=1683

Check warning on line 802 in src/Altinn.App.Core/Internal/Expressions/ExpressionEvaluator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loops should be simplified using the "Where" LINQ method

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQl6hgA_Kbzevocj&open=AZy-iQl6hgA_Kbzevocj&pullRequest=1683

Check warning on line 21 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocP&open=AZy-iQkPhgA_KbzevocP&pullRequest=1683

Check warning on line 268 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using this literal 'false' 7 times.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocY&open=AZy-iQkPhgA_KbzevocY&pullRequest=1683

Check warning on line 137 in src/Altinn.App.Core/Internal/App/IAppResources.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQm3hgA_Kbzevocm&open=AZy-iQm3hgA_Kbzevocm&pullRequest=1683

Check warning on line 616 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocV&open=AZy-iQkPhgA_KbzevocV&pullRequest=1683

Check failure on line 412 in src/Altinn.App.Core/Implementation/AppResourcesSI.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not construct the path from user-controlled data.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQvqhgA_Kbzevodh&open=AZy-iQvqhgA_Kbzevodh&pullRequest=1683

Check warning on line 360 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocU&open=AZy-iQkPhgA_KbzevocU&pullRequest=1683

Check failure on line 477 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 24 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_Kbzevoca&open=AZy-iQkPhgA_Kbzevoca&pullRequest=1683

Check warning on line 235 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocp&open=AZy-iQnyhgA_Kbzevocp&pullRequest=1683

Check warning on line 265 in src/Altinn.App.Core/Internal/Expressions/LayoutEvaluatorState.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All 'AddInidicies' method overloads should be adjacent.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQk9hgA_Kbzevocc&open=AZy-iQk9hgA_Kbzevocc&pullRequest=1683

Check warning on line 435 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevoc0&open=AZy-iQnyhgA_Kbzevoc0&pullRequest=1683

Check failure on line 149 in src/Altinn.App.Core/Helpers/DataModel/DataModelWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 26 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQuihgA_Kbzevodb&open=AZy-iQuihgA_Kbzevodb&pullRequest=1683

Check warning on line 760 in src/Altinn.App.Core/Internal/Expressions/ExpressionEvaluator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loops should be simplified using the "Where" LINQ method

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQl6hgA_Kbzevoci&open=AZy-iQl6hgA_Kbzevoci&pullRequest=1683

Check warning on line 188 in src/Altinn.App.Core/Features/DataProcessing/DataFieldValueCalculator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'ResolveDataFieldCalculation' does not access instance data and can be marked as static

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzXXHJQkz7ky6K7ODVM&open=AZzXXHJQkz7ky6K7ODVM&pullRequest=1683

Check warning on line 39 in src/Altinn.App.Core/Internal/Data/IFormDataWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename virtual/interface member IFormDataWrapper.Get(ReadOnlySpan<char>) so that it no longer conflicts with the reserved language keyword 'Get'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQjUhgA_KbzevocN&open=AZy-iQjUhgA_KbzevocN&pullRequest=1683

Check warning on line 91 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s).

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocn&open=AZy-iQnyhgA_Kbzevocn&pullRequest=1683

Check warning on line 647 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocW&open=AZy-iQkPhgA_KbzevocW&pullRequest=1683