Support objects in expressions by TomasEng · Pull Request #1777 · Altinn/app-lib-dotnet

TomasEng · 2026-05-28T09:30:16Z

Important

This pull request is stacked upon #1769, which should be merged first.

Description

This pull request adds support for objects in expressions, along with an object function for creating an object. Here is an overview of the changes:

New object function in ExpressionEvaluator. Because of the complexity of the function, I created a separate class named ObjectFunctionEvaluator for evaluating the function.
Support for dictionaries in ExpressionValue. Most of the code did already exist, hiding in comments.

Here is the corresponding change in App frontend: Altinn/altinn-studio#18982

Related Issue(s)

Support objects in expressions app-frontend-react#4190

Verification

Your code builds clean without any errors or warnings
Manual testing not possible since there is no use case for this until we add functions that accept objects as parameters; the automated unit tests should be sufficient
Relevant automated test added (if you find this hard, leave it and we'll help out)
All tests run green

Documentation

User documentation is updated with a separate linked PR in altinn-studio-docs.: Add docs about lists and objects in expressions altinn-studio-docs#2894

coderabbitai · 2026-05-28T09:30:25Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ecbdc9f6-682f-45e5-a0f6-0c6874bb8910

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch support-objects-in-expressions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

TomasEng · 2026-05-29T07:10:58Z

+#pragma warning disable CA1720
    @object,
+#pragma warning restore CA1720


Sonar complained about this variable having a name that contains "object", but we need this for the object function to work.

TomasEng · 2026-05-29T08:00:03Z

@coderabbitai review

coderabbitai · 2026-05-29T08:00:11Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…to support-objects-in-expressions # Conflicts: # src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs # test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

olavsorl

Kjørte claude på denne også, stortsett bare pirking. Fant noe selv også. Sikkert fint om du får @ivar til å se over også

olavsorl · 2026-06-09T10:13:43Z

+
+namespace Altinn.App.Core.Internal.Expressions;
+
+internal sealed class ObjectFunctionEvaluator


Du laget vell en mappe for disse klassene som vi diskuterte i den andre PRen?

Ja, den blir opprettet i PR-en for Jmespath. Her har vi bare én slik klasse, så da tenker jeg uansett ikke at det er nødvendig med en egen mappe.

olavsorl · 2026-06-09T11:44:06Z

            JsonValueKind.False => "false",
            JsonValueKind.String => String,
            JsonValueKind.Number => Number.ToString(CultureInfo.InvariantCulture),
            // JsonValueKind.Object => JsonSerializer.Serialize(Object),


Hva med denne, utenfor scope?

Ja. Så vidt jeg forstår brukes den når man caster til streng, og det er ikke noe vi støtter for objekter (i hvert fall ikke foreløpig).

olavsorl · 2026-06-09T11:54:40Z


    /// <summary>Get the value as an object (or throw if it isn't an object ValueKind)</summary>
-    public Dictionary<string, ExpressionValue> Dictionary =>
+    public JsonObject Dictionary =>


Bør kanskje rename Dictionary, nå når det ikke er en Dictionary lenger?

Kalte den det fordi Sonar klagde på "Object". Har du noen andre forslag?

olavsorl · 2026-06-09T11:57:11Z

    public ObjectFunctionEvaluator(ExpressionValue[] args) => _args = args;

-    public Dictionary<string, ExpressionValue> Evaluate()
+    public JsonObject Evaluate()


Claude skriver:

LINQ density (style nit): ObjectFunctionEvaluator.Evaluate makes several passes over _args (Where ×2, Distinct, Zip, ToDictionary). Fine for the tiny arg counts expected, but AGENTS.md notes "sometimes a for loop is just as good as LINQ" — a single loop could build the dict, detect odd-count, dup keys, and bad key types in one pass. Optional.

Jeg kan ikke se hvordan en løkke vil gjøre dette mer oversiktlig. Løkker er vanskelige å lese. Verktøy som CodeQL foreslår jo ofte å bytte ut løkker med nettopp Linq. Jeg kan eventuelt dele opp i flere funksjoner, for eksempel ExtractEvenArguments og ExtractOddArguments for Where-biten.

La til disse metodene nå. Det ble mer ryddig.

olavsorl · 2026-06-09T17:12:11Z

+        {
+            throw new JsonException("Expected StartObject token.");
+        }
+        var values =


Småpirk, men values i flertallsform henger sikkert igjen fra dette var Dictionary?

olavsorl · 2026-06-09T17:23:41Z

+        }
+        var values =
+            JsonSerializer.Deserialize<JsonObject>(ref reader, options)
+            ?? throw new JsonException("Expected EndObject token.");


Er det riktig å anta at dersom Deserialize returnerer null så mangler endObject token, finnes det ikke andre tilfeller der Deserialize kan returnere null?

Nei, Deserialize feiler vel uansett hva som det er som gjør at verdien ikke kan omgjøres til JsonObject. Godt sett! Skal gjøre feilmeldingen mer riktig.

Co-authored-by: olavsorl <olav.sorlie@digdir.no>

…xpressions

sonarqubecloud · 2026-06-10T09:46:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

TomasEng added feature Label Pull requests with new features. Used when generation releasenotes backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels May 28, 2026

TomasEng force-pushed the support-objects-in-expressions branch from 5a4dacc to 5c9c571 Compare May 28, 2026 13:12

TomasEng mentioned this pull request May 29, 2026

feat: Support objects in frontend expressions Altinn/altinn-studio#18982

Open

3 tasks

TomasEng added this to Team Altinn Studio May 29, 2026

TomasEng added the squad/data Issues that belongs to the named squad. label May 29, 2026

TomasEng moved this to 👷 In progress in Team Altinn Studio May 29, 2026

TomasEng force-pushed the support-objects-in-expressions branch from 2fb14e2 to ee69ba5 Compare May 29, 2026 07:00

TomasEng commented May 29, 2026

View reviewed changes

TomasEng force-pushed the support-objects-in-expressions branch 2 times, most recently from 4908de3 to 2a553d2 Compare May 29, 2026 07:33

Support objects in expressions

ab5d0b1

TomasEng force-pushed the support-objects-in-expressions branch from 2a553d2 to ab5d0b1 Compare May 29, 2026 07:40

TomasEng marked this pull request as ready for review May 29, 2026 08:02

TomasEng moved this from 👷 In progress to 🔎 In review in Team Altinn Studio May 29, 2026

TomasEng added 3 commits June 1, 2026 08:49

Merge remote-tracking branch 'origin/support-lists-in-expressions' in…

f35a9ea

…to support-objects-in-expressions # Conflicts: # src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs # test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

Use JsonObject

a5fa375

Seal ObjectFunctionEvaluator

d14e010

TomasEng mentioned this pull request Jun 3, 2026

Add Jmespath expression function #1790

Open

5 tasks

olavsorl self-assigned this Jun 9, 2026

olavsorl approved these changes Jun 9, 2026

View reviewed changes

TomasEng and others added 6 commits June 10, 2026 08:27

Update src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

6335458

Co-authored-by: olavsorl <olav.sorlie@digdir.no>

Update src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

1b629f7

Co-authored-by: olavsorl <olav.sorlie@digdir.no>

Update src/Altinn.App.Core/Models/Expressions/ExpressionFunction.cs

4f08e2b

Co-authored-by: olavsorl <olav.sorlie@digdir.no>

Revert uncomment of unused code

e4a90c0

Refactor ObjectFunctionEvaluator

df8320c

Rename variable

2b2a86b

Correct error message

4568156

TomasEng requested a review from olavsorl June 10, 2026 07:19

Merge branch 'support-lists-in-expressions' into support-objects-in-e…

58c2757

…xpressions


		namespace Altinn.App.Core.Internal.Expressions;

		internal sealed class ObjectFunctionEvaluator

Conversation

TomasEng commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Verification

Documentation

Uh oh!

coderabbitai Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomasEng commented May 29, 2026

Uh oh!

coderabbitai Bot commented May 29, 2026

Uh oh!

olavsorl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomasEng Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomasEng Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomasEng Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 10, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TomasEng commented May 28, 2026 •

edited

Loading

coderabbitai Bot commented May 28, 2026 •

edited

Loading

TomasEng Jun 10, 2026 •

edited

Loading

TomasEng Jun 10, 2026 •

edited

Loading

TomasEng Jun 10, 2026 •

edited

Loading