Fix memory issues revealed by cmake+GCC15 compile#1179
Merged
drroe merged 11 commits intoAmber-MD:masterfrom Apr 14, 2026
Merged
Fix memory issues revealed by cmake+GCC15 compile#1179drroe merged 11 commits intoAmber-MD:masterfrom
drroe merged 11 commits intoAmber-MD:masterfrom
Conversation
added 11 commits
April 14, 2026 08:43
…] in std::copy to access array begin and end pointers. However, this fails if idx+end is equal to the actual end of the array with gcc15/cmake (since technically array[idx+end] is an illegal access). Change this so that the pointers are calculated without the illegal access.
…lt. Protect against this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V7.6.2.
The Gcc15 compile with CMAKE is a lot less forgiving of memory issues. This PR fixes some long-standing memory issues that have gone unnoticed, or old "hacks" that will no longer work as of gcc15.