Fix some minor PostgreSql issues - #33
Merged
Merged
Conversation
…db issues, but also pass integration tests.
Fix edge case in 'Not' processing, introduced with the other 'not' fix
This issue was caused by a combination of a recent changes to keepIdentity handling and some legacy handling that automatically enables keepIdentity whenever a table has an identity value. As there was no way to override the behavior it was no longer possible to autogenerate identity values, as we (and probably our users) do in many scenarios. This caused > 20 test failures. As there is no easy way to unbreak this I removed the automatically setting keep-identity and cleaned up the arguments to properly allow setting the value as normal Enum (without nullable wrapper). At the same time I introduced ILogger like in the non-bulk api and forwarded that wherever possible (and where I did not forget something). This fixes all the SqlServer Bulkinsert integrationtests.
… testing. Use that for GitHub action. Upgrade packages to versions that have no security reports.
…tests Fix all unit and integration tests.
Support int and short in SetEntityIdentities for PostGres
…meout-get-fields Updates GetCommandText() to use pg_index catalog in PostgreSqlDbHelper
rhuijben
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch-up with the last few changes in the original RepoDB repository.