Added: Add language switcher support and enhance Experiment component#1442
Draft
drikusroor wants to merge 13 commits intodevelopfrom
Draft
Added: Add language switcher support and enhance Experiment component#1442drikusroor wants to merge 13 commits intodevelopfrom
drikusroor wants to merge 13 commits intodevelopfrom
Conversation
… up imports and improve code readability;
… improve data fetching logic
…sent styling; enhance `Experiment` model with language support
…ty but with a value of `None`
drikusroor
changed the title
… old experiment until new experiment has been loaded (loading spinner thus won't "flash" in between)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds language switch buttons above the
Contentcomponent on theExperimentpage component. When clicking the language switcher button, the experiment will be re-fetched with a language parameter and subsequently uses theactivatefunction to set the language cookie.This PR can be considered a draft/prototype as we haven't really planned, specified, and designed this feature but is intended to start a conversation.
Screencap
Screen.Recording.2024-12-19.at.13.27.48.mov
Summary
Introduce a LanguageSwitcher for selecting languages, enhance the Experiment model to support multiple languages, and improve data fetching logic in the useGet hook. Additionally, implement customizable button sizes and enhance tests for the new functionality.