Draft
Conversation
BeritJanssen
commented
Mar 31, 2025
| {/* Also contains the statistics */} | ||
| {/* <div className="aha__final-text"> | ||
| <div dangerouslySetInnerHTML={{ __html: final_text }} /> | ||
| </div> */} |
Collaborator
Author
There was a problem hiding this comment.
Commented out code is not a good idea in general, it makes it very hard to understand what has been changed.
BeritJanssen
commented
Mar 31, 2025
Collaborator
Author
There was a problem hiding this comment.
This belongs into the assets, or, even better, should be uploaded through the admin interface.
BeritJanssen
commented
Mar 31, 2025
Collaborator
Author
BeritJanssen
left a comment
BeritJanssen
left a comment
There was a problem hiding this comment.
@bacor , I looked over the code. Some general comments:
- logos should be uploaded through the backend
- svgs like star, dot etc. perhaps to be moved to assets, and let the component only do the animation / sizing etc.
- don't comment out code. If you're not sure whether it should be dropped, version control is always there to bring it back.
- I'm rather opposed to calling the theme for TuneTwins "MCG Theme", since the original theme has also been developed by the MCG. :-)
- As the code stands, it will interfere with non-TuneTwins projects, so I vote against merging it into the existing code base
- Seeing as the code also introduces more than 2'000 lines which would need to be integrated and maintained, I would advise keeping it on a separate branch for now, and deploying it to its own server or container network.
Tt/fix translations
Update translations
…tamp fix: add timestamp to backend API call
This reverts commit d51cc65.
…ore-feedback Feature/tunetwins more feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate branch for Tunetwins game 2.0, not to be merged at this moment.