Skip to content

feat(app): add UnifiedPush support for github flavor#1231

Merged
wax911 merged 2 commits into
developfrom
feat/202-app-add-unifiedpush-support-for-githubf-droid-build-flavours-as-a-non-google-push-transport
Jun 9, 2026
Merged

feat(app): add UnifiedPush support for github flavor#1231
wax911 merged 2 commits into
developfrom
feat/202-app-add-unifiedpush-support-for-githubf-droid-build-flavours-as-a-non-google-push-transport

Conversation

@wax911

@wax911 wax911 commented Jun 9, 2026

Copy link
Copy Markdown
Member

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure you've done the following:

  • You have followed our contributing guidelines
  • Double checked that your branch is based on develop and targets develop (where applicable)
  • Pull request has tests (if applicable)
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved

Description

Implements #202 by adding UnifiedPush support to the github flavor as a non-Google push transport.

This change adds the UnifiedPush connector dependency and GitHub-flavor manifest services, wires startup registration through a flavor-specific initializer and Koin module, and persists the active UnifiedPush endpoint through the repo's data/settings + Settings pattern instead of a standalone preference wrapper. It also keeps the Google flavor on Firebase Messaging unchanged.

Verification:

  • ./gradlew --quiet :app:testGithubDebugUnitTest --tests co.anitrend.push.PushRegistrationCoordinatorTest
  • ./gradlew --quiet :app:compileGithubDebugKotlin
  • ./gradlew --quiet :app:compileGoogleDebugKotlin
  • ./gradlew --quiet spotlessApply

Screenshots:

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (Improves existing functionality)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the GPL v3 License.

@codacy-production

codacy-production Bot commented Jun 9, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 medium

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
Complexity 2 medium

View in Codacy

🟢 Metrics 29 complexity

Metric Results
Complexity 29

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@wax911 wax911 force-pushed the feat/202-app-add-unifiedpush-support-for-githubf-droid-build-flavours-as-a-non-google-push-transport branch from f86956f to 89d81d4 Compare June 9, 2026 15:13

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved automated PR

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: wax911 <7859175+wax911@users.noreply.github.com>
@wax911 wax911 enabled auto-merge (squash) June 9, 2026 15:19
@wax911 wax911 merged commit 6c9c29f into develop Jun 9, 2026
9 of 11 checks passed
@wax911 wax911 deleted the feat/202-app-add-unifiedpush-support-for-githubf-droid-build-flavours-as-a-non-google-push-transport branch June 9, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[app] Add UnifiedPush support for GitHub/F-Droid build flavours as a non-Google push transport

1 participant