fix(build): publish all library modules with component-backed Maven artifacts (#414)#415
Open
wax911 wants to merge 2 commits into
Open
fix(build): publish all library modules with component-backed Maven artifacts (#414)#415wax911 wants to merge 2 commits into
wax911 wants to merge 2 commits into
Conversation
…rtifacts (#414) Replace the broken manual-AAR publishing (which only worked for the deprecated :library facade) with AGP component-backed publications for every consumable module. Android modules: - Configure singleVariant("release") + withSourcesJar() in buildSrc - Create MavenPublication from components.release in afterEvaluate (component doesn't exist until after AGP task graph resolution) - artifactId = project.name (except :library, kept as retrofit-graphql for backward compatibility) - Removed dead code: manual sourcesJar/classesJar tasks, artifacts block JVM modules (:annotations, :codegen-core): - Inline maven-publish + publication from components.java directly in each build file (composite build classpath prevents buildSrc helper) - sourcesJar created manually (AGP's withSourcesJar is Android-only) All 8 modules now publish to Maven local with correct artifactIds, version v0.12.0, and POM metadata.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
- Restore logger.lifecycle calls in configurePublishing() - Extract duplicated JVM publishing into configureJvmPublishing() helper in buildSrc JvmConfiguration.kt - Add no-op stub for composite build's JvmConfiguration.kt to avoid resolution failures in the gradle-plugin composite build context - Simplify annotations/build.gradle.kts (54→12 lines) and codegen-core/build.gradle.kts (61→19 lines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #414
Changes
Verification