fix(codegen): iteratively inline nested fragment spreads#426
Merged
Conversation
AstTransformer does not recursively visit children of nodes inserted via TreeTransformerUtil.changeNode, so a single transformation pass leaves nested fragment spreads (e.g. ...MediaTitleFragment inside ...MediaCoreFragment) unresolved in the generated document. Replace the single-pass approach with an iterative loop that re-parses and re-transforms until no FragmentSpread nodes remain. The defensive invariant check is now the loop exit condition rather than a post-hoc assertion that could throw on deeply nested fragments. Follow-up to #424.
Add all composite-build and subproject modules to the IDE Gradle project settings so they are recognised by the IDE. Update the Kotlin compiler version from 2.0.21 to 2.4.0 to match the project toolchain.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #424. The original recursive fragment resolution fix assumed that
AstTransformerrecursively visits the children of nodes inserted viaTreeTransformerUtil.changeNode. In practice it does not, so a single transformation pass leaves nested fragment spreads (e.g....MediaTitleFragmentinside...MediaCoreFragment) unresolved in the generated document, producing invalid GraphQL requests.Root Cause
flattenFragments()performed a singletransformer.transform(document, spreadVisitor)pass and then asserted noFragmentSpreadnodes remained. BecauseAstTransformerdoes not descend into children of replacement nodes, any fragment spread nested inside an inlined fragment definition was left as an unresolved named spread.Fix
Replace the single-pass approach with an iterative loop:
spreadVisitoruntilcollectSpreadNamesreturns an empty set.The defensive invariant check is now the loop exit condition rather than a post-hoc assertion that could throw on deeply nested fragments.
Additional changes
chore(ide): update IDE Gradle project settings to include all composite-build and subproject modules, and update the Kotlin compiler version from 2.0.21 to 2.4.0 to match the project toolchain.Types of changes