Skip to content

Add CI workflow to build the solution on .NET 10 - #4

Merged
AntwerpDesignsIonity merged 1 commit into
Root-Mainfrom
claude/openrgb-system-integration-SlHjT
Jun 14, 2026
Merged

Add CI workflow to build the solution on .NET 10#4
AntwerpDesignsIonity merged 1 commit into
Root-Mainfrom
claude/openrgb-system-integration-SlHjT

Conversation

@AntwerpDesignsIonity

@AntwerpDesignsIonity AntwerpDesignsIonity commented Jun 4, 2026

Copy link
Copy Markdown
Owner

Adds a CI build so the code actually gets compiled

The Claude Code web/sandbox environment blocks all package egress — every Ubuntu mirror, the .NET install CDN, and api.nuget.org return host_not_allowed, and there's no pre-installed SDK or NuGet cache. So PR #3 (OpenRGB auto-start + per-zone control) could not be compiled before merging.

This workflow restores and builds the whole FANZI.slnx solution on a windows-latest runner with the .NET 10 SDK, on every push to Root-Main / claude/** and on PRs. It gives a real compile check going forward — and this PR's own run compiles the just-merged OpenRGB/per-zone code.

If the build surfaces any errors in the merged changes, I'll push fixes.

https://claude.ai/code/session_01YGB3sD3FhoQawLLipwNkY7


Generated by Claude Code

Summary by Sourcery

CI:

  • Introduce a GitHub Actions workflow to restore and build FANZI.slnx with .NET 10 on windows-latest for Root-Main and claude/** branches, pull requests, and manual dispatch.

The web/sandbox environment blocks all package egress (Ubuntu mirrors, the
.NET install CDN and nuget.org all return host_not_allowed), so the project
can't be compiled there. This GitHub Actions workflow restores and builds the
whole solution on a windows-latest runner with the .NET 10 SDK, giving a real
compile check on every push and PR.
@sourcery-ai

sourcery-ai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Reviewer's Guide

.github/workflows/build.yml adds a Windows-based GitHub Actions workflow that restores and builds the FANZI.slnx solution using the .NET 10 SDK on pushes, PRs, and manual dispatch.

Flow diagram for new GitHub Actions .NET 10 CI build workflow

flowchart LR
  Trigger["push to Root-Main or claude/**\nPR to Root-Main\nworkflow_dispatch"] --> Job["Job build (Windows, .NET 10)"]
  Job --> Checkout["Step Checkout\nactions/checkout@v4"]
  Checkout --> SetupDotnet["Step Setup .NET 10\nactions/setup-dotnet@v4\n dotnet-version 10.0.x"]
  SetupDotnet --> Restore["Step Restore\ndotnet restore FANZI.slnx"]
  Restore --> Build["Step Build (Release)\ndotnet build FANZI.slnx --configuration Release --no-restore"]
Loading

File-Level Changes

Change Details Files
Introduce a Windows GitHub Actions CI workflow that restores and builds the FANZI.slnx solution with .NET 10.
  • Configure workflow triggers for pushes to Root-Main and claude/** branches, pull requests targeting Root-Main, and manual workflow_dispatch runs.
  • Run the job on a windows-latest runner and label it as a .NET 10 build.
  • Check out the repository using actions/checkout@v4.
  • Install the .NET 10 SDK using actions/setup-dotnet@v4 with version 10.0.x.
  • Restore NuGet packages for FANZI.slnx before building.
  • Build FANZI.slnx in Release configuration without re-running restore.
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AntwerpDesignsIonity
AntwerpDesignsIonity marked this pull request as ready for review June 14, 2026 00:20
@AntwerpDesignsIonity
AntwerpDesignsIonity merged commit 262a3ec into Root-Main Jun 14, 2026
4 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider enabling NuGet package caching via actions/setup-dotnet (e.g. cache: true) to speed up restores and reduce load on package feeds for frequent pushes.
  • For improved supply-chain security and reproducibility, pin actions/checkout and actions/setup-dotnet to specific commit SHAs instead of the floating @v4 tag.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider enabling NuGet package caching via `actions/setup-dotnet` (e.g. `cache: true`) to speed up restores and reduce load on package feeds for frequent pushes.
- For improved supply-chain security and reproducibility, pin `actions/checkout` and `actions/setup-dotnet` to specific commit SHAs instead of the floating `@v4` tag.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant