#423 remove unneeded log messages#435
Merged
Merged
Conversation
Antynea
changed the title
There was a problem hiding this comment.
Pull request overview
Reduces alarming "error" log noise for expected no-op exit conditions in 41_snapshots-btrfs. Introduces print_info/print_warning helpers and reclassifies four benign early-exit paths (disabled config, missing btrfs-progs, non-btrfs root, no snapshots found) from print_error (which prints a bug-report URL) to informational messages, while keeping a clean exit 0.
Changes:
- Add
print_infoandprint_warninglogging helpers, all prefixed withgrub-btrfs:and written to stderr. - Update
print_errorto use thegrub-btrfs: Error:prefix. - Reclassify benign exit conditions (
GRUB_BTRFS_DISABLE, missingbtrfs, non-btrfs root, no snapshots found) fromprint_errortoprint_info+ explicitexit 0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Antynea
added a commit
that referenced
this pull request
May 30, 2026
The "Detecting snapshots ..." message was still a bare printf and bypassed the logging helpers added in #435. Use print_info so it carries the "grub-btrfs:" prefix; the trailing newline is handled by the helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #423