Skip to content

Fix empty fs_uuid on multi-device Btrfs #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkocustos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix empty fs_uuid on multi-device Btrfs #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions 41_snapshots-btrfs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@ fi
# -----------------------------------------------------------

# ---------- Root partition ----------
root_device="$(${grub_probe} --target=device /)" # e.g. /dev/mapper/enc
# head -n1: on a multi-device Btrfs, grub-probe prints one device per line.
# Passing all of them to --device makes the fs_uuid probe return empty, so
# keep only the first device (any member yields the pool-wide fs UUID).
root_device="$(${grub_probe} --target=device / | head -n1)" # e.g. /dev/mapper/enc
root_uuid="$(${grub_probe} --device "${root_device}" --target=fs_uuid 2>/dev/null)" || true

# Fallback when grub-probe fails (encrypted container, detached header…)
Expand All @@ -135,7 +138,7 @@ root_uuid_subvolume="$(btrfs subvolume show / 2>/dev/null | \
[ -z "$root_uuid_subvolume" ] && print_error "UUID of the root subvolume is not available"

# ---------- Boot partition ----------
boot_device="$(${grub_probe} --target=device "${boot_directory}")" # e.g. /dev/sdb1
boot_device="$(${grub_probe} --target=device "${boot_directory}" | head -n1)" # e.g. /dev/sdb1; head -n1: see root_device above (multi-device Btrfs)
boot_uuid="$(${grub_probe} --device "${boot_device}" --target=fs_uuid 2>/dev/null)" || true

# Fallback for boot UUID
Expand Down