Fix Windows wheel smoke test venv usage#3852
Open
wuyua9 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows wheel smoke script currently activates the test virtualenv inside a separate
bash.exe -cprocess. That activation does not persist for the following install/import steps, so the smoke test can run against the wrong interpreter environment.This keeps the temporary directory, virtualenv activation, wheel install, and import check in the same shell session. It also asserts that both the Python executable and imported
web3package come from thevenv-testenvironment.Tests
bash -n web3/scripts/release/test_windows_wheel_install.shgit diff --check origin/main...HEADweb3/scripts/release/test_windows_wheel_install.shThe Windows-specific script was not executed locally because this environment is not the CircleCI Windows executor.