Skip to content

tests: fix thresholdEdgeCases.test.ts TypeScript errors - #51

Merged
usmanimamu17-create merged 1 commit into
ApexChainx:mainfrom
nelly439:fix/threshold-edgecases
Jun 22, 2026
Merged

tests: fix thresholdEdgeCases.test.ts TypeScript errors#51
usmanimamu17-create merged 1 commit into
ApexChainx:mainfrom
nelly439:fix/threshold-edgecases

Conversation

@nelly439

Copy link
Copy Markdown
Contributor

Description

Brief description of the changes in this PR.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Related Issues

Fixes #(issue number) or relates to #(issue number)

Changes Made

Testing

Describe the testing performed to validate these changes:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented complex logic
  • I have updated relevant documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes do not introduce new warnings
    close perf: hoist get_failure_schema symbols to compile-time constants #45

Copy link
Copy Markdown
Contributor

Thanks for the cleanup @nelly439! Before merging, can you double-check the closing issue? Your PR body references close #45, but issue #45 is about a Rust performance optimization — hoisting get_failure_schema symbols to compile-time constants in apexchainx_calculator/src/lib.rs. This PR only touches TypeScript files (tests/thresholdEdgeCases.test.ts + new types/jest-globals.d.ts), so the link doesn't line up with the changes. Could you update the PR description to point at the right issue, or open a new one describing the TypeScript fix so the close-reference matches the work? Once that's clarified I'll happily merge.

@usmanimamu17-create

Copy link
Copy Markdown
Contributor

better still, resolve the issue assigned to you.

Copy link
Copy Markdown
Contributor

Thanks for cleaning up the TypeScript errors, @nelly439! Tests behave now and the new jest globals shim is a nice touch. Merging. ✅

@usmanimamu17-create
usmanimamu17-create merged commit 6638dcb into ApexChainx:main Jun 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: hoist get_failure_schema symbols to compile-time constants

2 participants