feat: add Windows support for GuardedStack and ignore Miri tests for …#57
Merged
Conversation
…async fiber and concurrency benchmarks
panayang
added
enhancement
github-project-automation
Bot
moved this to Backlog
in This week's contribution option in Apich - internal
github-project-automation
Bot
moved this to Backlog
in This week's contribution option in Apich - external
panayang
marked this pull request as ready for review
March 31, 2026 05:50
panayang
moved this from Backlog
to In review
in This week's contribution option in Apich - internal
panayang
moved this from Backlog
to In review
in This week's contribution option in Apich - external
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Windows support for the GuardedStack implementation within the async-fiber feature, utilizing VirtualAlloc, VirtualProtect, and VirtualFree for memory management. It also includes a Windows-specific page_size implementation and a winapi_shim module for necessary FFI declarations. Furthermore, several asynchronous and high-concurrency tests, as well as a README example, have been updated to be ignored during Miri execution. I have no feedback to provide.
github-project-automation
Bot
moved this from In review
to Done
in This week's contribution option in Apich - external
github-project-automation
Bot
moved this from In review
to Done
in This week's contribution option in Apich - internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…async fiber and concurrency benchmarks