Skip to content

Update README.md with OpenHarmony build project#388

Closed
foreveruzi wants to merge 1 commit into
AprilRobotics:masterfrom
foreveruzi:openharmony
Closed

Update README.md with OpenHarmony build project#388
foreveruzi wants to merge 1 commit into
AprilRobotics:masterfrom
foreveruzi:openharmony

Conversation

@foreveruzi

Copy link
Copy Markdown

We support build project of OHpro in OpenHarmony, so we'd like to contribute it. Hope my PR can help developers use this library.

@christian-rauch christian-rauch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is obviously an unresolved merge conflict in the README.md. Did you check the commits before sending the PR?

The instructions are quite verbose. Essentially, you only have to provide the CMAKE_TOOLCHAIN_FILE to make this work. It looks to me that these instructions apply to any CMake project and that there is nothing special about apriltag here.

Instead of this verbose instructions, could you just link to the OpenHarmony documentation on how to install and use the SDK? Also, to make sure that this continues to work, can you add a CI pipeline to cross-compile with the latest OpenHarmony SDK?

@foreveruzi

Copy link
Copy Markdown
Author

There is obviously an unresolved merge conflict in the README.md. Did you check the commits before sending the PR?

The instructions are quite verbose. Essentially, you only have to provide the CMAKE_TOOLCHAIN_FILE to make this work. It looks to me that these instructions apply to any CMake project and that there is nothing special about apriltag here.

Instead of this verbose instructions, could you just link to the OpenHarmony documentation on how to install and use the SDK? Also, to make sure that this continues to work, can you add a CI pipeline to cross-compile with the latest OpenHarmony SDK?

There is obviously an unresolved merge conflict in the README.md. Did you check the commits before sending the PR?

The instructions are quite verbose. Essentially, you only have to provide the CMAKE_TOOLCHAIN_FILE to make this work. It looks to me that these instructions apply to any CMake project and that there is nothing special about apriltag here.

Instead of this verbose instructions, could you just link to the OpenHarmony documentation on how to install and use the SDK? Also, to make sure that this continues to work, can you add a CI pipeline to cross-compile with the latest OpenHarmony SDK?

Thank for your suggestion.we will adopt it and make the necessary modifications bedore resubmitting a new one.

@christian-rauch

Copy link
Copy Markdown
Collaborator

@foreveruzi Are you still interested in this PR?

@christian-rauch

Copy link
Copy Markdown
Collaborator

I am closing this now since there seems to be no interest in addressing the comments and getting this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants