You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Windows crosscompilation is broken again. This fixes the issue. This is due to the fact that in mingw, Winsock2.h is winsock2.h, and is case sensitive. Might be winsock2.h in windows too, but I don't have a computer running windows to check, sadly.
For the CI part, it is way trickier than expected as I build it on linux and run it on windows.
I don't want to change cmake-multi-platform.yml too much.
How would you like me to do it?
The cmake-multi-platform.yml loops over the Linux/macOS/Windows runners and runs the same procedure "natively" on the runner. I guess it is a bit complicated to squeeze the cross-compilation in there. I would create a new "cross-compilation" workflow to separate this better.
Will test the CI on my side and reopen when ready, don't want to spam you
You can also open PRs in "Draft" state. I think that this does not send out notifications unless you switch it to "Ready".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows crosscompilation is broken again. This fixes the issue. This is due to the fact that in mingw,
Winsock2.hiswinsock2.h, and is case sensitive. Might bewinsock2.hin windows too, but I don't have a computer running windows to check, sadly.