fix: windows crosscompilation and added a workflow to test it by crosscompiling on ubuntu and running tests on windows#402
Merged
Conversation
Contributor
Author
|
So here we are again, with the |
christian-rauch
left a comment
christian-rauch
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Can you maybe just add some info in the commit message and the PR what is happening here and why this is required?
VincentMarnier
changed the title
christian-rauch
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When crosscompiling for windows,
Winsock2.his not found, because theincludestatement is case sensitive and the header's names iswinsock2.hinstead ofWinsock2.h.We now checks which is present and use it.
Also added a workflow to test the cross compilation by building (using mingw) on ubuntu and running the tests on windows.