Skip to content

Use path halving in unionfind to improve performance#404

Merged
christian-rauch merged 1 commit into
AprilRobotics:masterfrom
jvanvugt:joris/path-halving-union-find
Oct 7, 2025
Merged

Use path halving in unionfind to improve performance#404
christian-rauch merged 1 commit into
AprilRobotics:masterfrom
jvanvugt:joris/path-halving-union-find

Conversation

@jvanvugt

@jvanvugt jvanvugt commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Do path halving instead of path compression in unionfind. This makes the clustering take approximately 46ms instead of 52ms on my 6MP test image.

@jvanvugt jvanvugt force-pushed the joris/path-halving-union-find branch 2 times, most recently from eeb228e to 606adbb Compare October 7, 2025 12:28
@christian-rauch christian-rauch marked this pull request as draft October 7, 2025 12:28
@christian-rauch

Copy link
Copy Markdown
Collaborator

I converted to Draft, since you are still pushing to the PR. Once you are ready for the actual review, mark this PR as ready and let me know.

@jvanvugt jvanvugt force-pushed the joris/path-halving-union-find branch from 606adbb to 717dab5 Compare October 7, 2025 12:29
@jvanvugt

jvanvugt commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

@christian-rauch I accidentally pushed to this branch instead of a new one for a different optimization. It's ready for your review now

@christian-rauch christian-rauch marked this pull request as ready for review October 7, 2025 13:46
@christian-rauch christian-rauch merged commit 2d0466d into AprilRobotics:master Oct 7, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants