Use local variables for line fit stats accumulation#405
Merged
christian-rauch merged 1 commit intoOct 13, 2025
Conversation
Allows them to be stored in CPU registers and avoids memcopy-ing the struct (cherry picked from commit e504236)
Contributor
Author
|
@christianrauch Perhaps you've missed this PR in the noise of my other PRs ;) Looking forward to your review. No worries if you haven't had time to look at it |
christian-rauch
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another performance optimization for quad fitting. Using local variables for the line fitting statistics allows them to be stored in CPU registers and avoids memcopy-ing the struct. This speeds up quad fitting from 46.6ms to 43.7ms averaged over 100 runs on my 6MP test image with 51 tags.