Address SonarQube reliability/type findings in CLM sample flows

[Copilot]

Description

Follow-up to the SonarQube feedback on PR #94 for the CLM demo: this narrows down reliability and type-safety issues in the newly added CLM codepaths (auth/access control, agreement create/sign, template edit, login title rendering).
The update focuses on removing unsafe patterns and tightening typings without changing feature scope.

• Access control cleanup

  • Removed unused callback parameters in auth and ACL handlers to eliminate noise and static-analysis flags.

• Agreement creation hardening

  • Added explicit null guards before using WebViewer/PDFNet instances and generated documents.
  • Replaced weak select-item typing with concrete UserSelectItem / TemplateSelectItem types.
  • Normalized and validated PDF buffer handling before base64 encoding to avoid unsafe assumptions.

• Agreement signing safety

  • Guarded WebViewer Core access before document/annotation operations.

• Template edit safety

  • Replaced non-null assertion usage with explicit Core existence checks.

• Login page type correctness

  • Updated ThemedTitle props to match current refine typings (text, collapsed).

const core = wvInstance.current?.Core;
if (!core) return;
const { documentViewer, annotationManager } = core;

Resources

• Review comment driving this stacked PR: Feature added clm demo #94 (review)
• SonarCloud PR dashboard referenced in feedback: https://sonarcloud.io/dashboard?id=ApryseSDK_webviewer-samples&pullRequest=94

Checklist

• I understand that this is a public repo and my changes will be publicly visible

If you are adding a new sample

• I have added an entry to the root level README
• The name of my sample is consistent with the other samples
• I have added a README to my sample
• The sample is fully functional
• I have updated lerna.json with the new sample name

If you are removing an old sample

• I have removed the entry from the root level README
• I have removed the sample from lerna.json

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• sonarcloud.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
• telemetry.refine.dev
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/webviewer-samples/webviewer-samples/webviewer-clm/node_modules/.bin/refine build (dns block)
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/webviewer-samples/webviewer-samples/webviewer-clm/node_modules/.bin/refine build r (dns block)
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/webviewer-samples/webviewer-samples/webviewer-clm/node_modules/.bin/refine build git mple�� get --global t committer.email (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[DavidEGutierrez]

These changes look good.

[jgozner]

LGTM

[jgozner-apryse]

LGTM

[DavidEGutierrez]

Looks good.