Skip to content

Correct handling of USB3Vision control endpoints#1053

Merged
EmmanuelP merged 2 commits into
AravisProject:mainfrom
27Cobalter:fix/500-u3v-control-endpoint
Jan 31, 2026
Merged

Correct handling of USB3Vision control endpoints#1053
EmmanuelP merged 2 commits into
AravisProject:mainfrom
27Cobalter:fix/500-u3v-control-endpoint

Conversation

@27Cobalter

Copy link
Copy Markdown
Contributor

Fixes #500

This change removes the incorrect assumption that endpoint_in == (endpoint_out | LIBUSB_ENDPOINT_IN). This was causing issues with cameras like the Toshiba-Teli BU406M (where OUT=0x01 but IN=0x82).

Summary of changes:

  • Stored control OUT and IN endpoints in separate variables with their raw values.
  • Removed the manual bitwise OR flag logic.
  • Updated log messages to show both endpoints in 2-digit hex format (consistent with libusb style).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug in USB3Vision control endpoint handling that prevented certain cameras (like the Toshiba-Teli BU406M/BU505MG) from working correctly.

Changes:

  • Separated control endpoint storage into distinct IN and OUT fields with raw endpoint addresses
  • Removed incorrect assumption that IN endpoint could be derived from OUT endpoint using bitwise OR
  • Updated endpoint selection logic to use stored values directly based on transfer direction

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EmmanuelP EmmanuelP merged commit e0269e5 into AravisProject:main Jan 31, 2026
11 checks passed
@EmmanuelP

Copy link
Copy Markdown
Contributor

Thanks @27Cobalter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to bootstrap USB device 'Toshiba-Teli:BU505MG:...'

3 participants