Correct handling of USB3Vision control endpoints#1053
Merged
EmmanuelP merged 2 commits intoJan 31, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in USB3Vision control endpoint handling that prevented certain cameras (like the Toshiba-Teli BU406M/BU505MG) from working correctly.
Changes:
- Separated control endpoint storage into distinct IN and OUT fields with raw endpoint addresses
- Removed incorrect assumption that IN endpoint could be derived from OUT endpoint using bitwise OR
- Updated endpoint selection logic to use stored values directly based on transfer direction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks @27Cobalter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
This change removes the incorrect assumption that endpoint_in == (endpoint_out | LIBUSB_ENDPOINT_IN). This was causing issues with cameras like the Toshiba-Teli BU406M (where OUT=0x01 but IN=0x82).
Summary of changes: