feat: experimental vectorized and numba parallelized implementation#44
Merged
Conversation
Collaborator
|
This is awesome, thanks @drbh ! I’ll do some testing and try to get this merged asap. |
Collaborator
|
thanks for the PR @drbh ! I'm going to test this more in a few different contexts and will eventually just make this the stable execution path for wilcoxon. cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a experimental implementation of
parallel_differential_expressionthat uses numpy vectorization,numbda.prangeand@njitto try to squeeze perf out of the CPU. With some empirical testing this sped up some operations by an order of magnitude.The changes include a
USE_EXPERIMENTALenv var to enable opt-in usage and transparently replace theparallel_differential_expression, and a newbench_expr.pythat compares the reference with the experimental impl.Running benches
current limitations: only the
wilcoxonmetric is implemented inparallel_differential_expression_vecMore realistic workload
In a slightly bigger example this reduces the compute time for a dataset of 100,000 cells, 18,080 genes and 150 perturbations from ~5 mins to ~25 seconds on my MacBook M3.
**(ref is using num_workers=16 and batch_size=100)