Skip to content

feat(metadata): add SURVEY ServiceDomain#880

Merged
samkujovich merged 1 commit into
mainfrom
feat/add-survey-service-domain
Jun 22, 2026
Merged

feat(metadata): add SURVEY ServiceDomain#880
samkujovich merged 1 commit into
mainfrom
feat/add-survey-service-domain

Conversation

@samkujovich

@samkujovich samkujovich commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a SURVEY value to the ServiceDomain enum in arcade_core.metadata.

Survey / form / questionnaire builders (Google Forms, Typeform, SurveyMonkey, Qualtrics, etc.) have no fitting ServiceDomain today — none of the existing values passes the 10/10 test for "is this a survey tool?". Per the tool-metadata convention, a missing-but-warranted category should be added upstream (the same path OBSERVABILITY took for Datadog) rather than forcing tools into the wrong domain or defaulting to None.

SURVEY = "survey"
"""Survey, form, and questionnaire builders for collecting and analyzing responses."""

First consumer

The Google Forms worker toolkit (ArcadeAI/monorepo#939). Its 21 tools currently ship without a Classification because no domain fit; once this releases, that toolkit will bump its arcade-mcp-server minimum and classify all tools as SURVEY.

Test plan

  • Adds test_decorator_accepts_survey_domain mirroring the existing per-domain acceptance tests.
  • New enum member only; no behavior change to existing domains.

Note

Low Risk
Additive enum member and version bump only; no changes to validation logic or existing ServiceDomain values.

Overview
Adds ServiceDomain.SURVEY ("survey") to arcade_core.metadata so survey, form, and questionnaire integrations (e.g. Google Forms) can be classified for discovery and search boosting instead of leaving Classification unset or mis-tagging another domain.

arcade-core is bumped 4.9.0 → 4.10.0 for the release. A decorator acceptance test test_decorator_accepts_survey_domain follows the same pattern as other per-domain tests; existing domains and validation rules are unchanged.

Reviewed by Cursor Bugbot for commit 1377fab. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
libs/arcade-core/arcade_core/metadata.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jottakka jottakka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a version bump!

Survey/form/questionnaire builders (Google Forms, Typeform, SurveyMonkey,
etc.) have no fitting ServiceDomain today. Add SURVEY so form-builder
toolkits can classify at the 10/10 bar instead of falling back to None.

First consumer: the Google Forms worker toolkit (ArcadeAI/monorepo#939).
@samkujovich samkujovich force-pushed the feat/add-survey-service-domain branch from b9f8ba0 to 1377fab Compare June 22, 2026 18:24
@samkujovich samkujovich merged commit 7930a43 into main Jun 22, 2026
48 checks passed
@samkujovich samkujovich deleted the feat/add-survey-service-domain branch June 22, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants