Refactor Codex Stop no-continuation assertions#612
Merged
TheMostlyGreat merged 1 commit intoJul 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #598 / #605 after rebasing onto main.\n\nWhat changed:\n- Extracted the repeated Codex Stop no-continuation JSON assertion into a test helper.\n- No production behavior changes.\n\nVerification:\n- SAFEWORD_TEST_LOCK_MAX_WAIT_MS=0 bun run --cwd packages/cli test tests/integration/codex-stop-nudge.test.ts\n- bun run --cwd packages/cli typecheck\n- bun run --cwd packages/cli lint:eslint\n- git diff --check\n