Bind review stamps to the session ticket#613
Merged
Merged
Conversation
This was referenced Jul 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write-review-stamp.tsagainst the session-bound active ticket before falling back to a globalin_progressscan.--ticketbehavior for manual disambiguation and stale/missing session bindings.in_progresstickets with and without a session-bound ticket.Fixes #564.
Notes
Issue #564 also mentioned
record-skill-invocation.ts, but current code does not scan tickets there. The reproducible failing path iswrite-review-stamp.ts, which this PR fixes.Verification
SAFEWORD_TEST_LOCK_DIR=/tmp/safeword-8935-review-stamp-test.lock bun run test tests/integration/review-stamp.test.tsbun run typecheckbunx eslint packages/cli/tests/integration/review-stamp.test.tsgit diff --check origin/main...HEADcmp -s packages/cli/templates/hooks/write-review-stamp.ts .safeword/hooks/write-review-stamp.tsbun audit --json