Skip to content

Bind review stamps to the session ticket#613

Merged
TheMostlyGreat merged 2 commits into
mainfrom
codex/issue-564-review-stamp-active-ticket
Jul 2, 2026
Merged

Bind review stamps to the session ticket#613
TheMostlyGreat merged 2 commits into
mainfrom
codex/issue-564-review-stamp-active-ticket

Conversation

@TheMostlyGreat

Copy link
Copy Markdown
Collaborator

Summary

  • Resolve write-review-stamp.ts against the session-bound active ticket before falling back to a global in_progress scan.
  • Keep explicit --ticket behavior for manual disambiguation and stale/missing session bindings.
  • Add integration coverage for multiple in_progress tickets with and without a session-bound ticket.
  • Reuse the shared second-ticket fixture in the review-stamp tests.

Fixes #564.

Notes

Issue #564 also mentioned record-skill-invocation.ts, but current code does not scan tickets there. The reproducible failing path is write-review-stamp.ts, which this PR fixes.

Verification

  • SAFEWORD_TEST_LOCK_DIR=/tmp/safeword-8935-review-stamp-test.lock bun run test tests/integration/review-stamp.test.ts
  • bun run typecheck
  • bunx eslint packages/cli/tests/integration/review-stamp.test.ts
  • git diff --check origin/main...HEAD
  • cmp -s packages/cli/templates/hooks/write-review-stamp.ts .safeword/hooks/write-review-stamp.ts
  • bun audit --json

@TheMostlyGreat TheMostlyGreat merged commit 41569c8 into main Jul 2, 2026
2 checks passed
@TheMostlyGreat TheMostlyGreat deleted the codex/issue-564-review-stamp-active-ticket branch July 2, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skill-invocation-log helpers fail closed when multiple tickets are in_progress

2 participants