Add execution_logging config to engine schema#25
Merged
Conversation
Document the execution_logging configuration block that was deferred from PR #146 until the config shape stabilized (PLT-1106). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
itsthatriver
force-pushed
the
thejosephstevens/exec-logging-schema
branch
from
b7d9ca2 to
c55b3e8
Compare
wdawson
reviewed
Feb 26, 2026
wdawson
left a comment
wdawson
left a comment
Contributor
There was a problem hiding this comment.
I think there's a "test" schema file here too. Can you update that and/or make sure it conforms to these updates? Helps to make sure that main won't break with bad config.
wdawson
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PLT-1106
Summary
execution_loggingas an optional top-level property toengine/config/2.0/schema.jsonenabled,max_output_size,buffer_size,write_batch_size,write_batch_timeout,drain_timeout,config_cache_ttl,coordinator_url) and acleanupsub-object with 3 fields (batch_size,mark_interval,sweep_batch_interval)oneOfwithenvVarPattern/filePatternrefs, descriptions, defaults, and validation constraintsCloses PLT-1106. Deferred from PR #146 until the config shape stabilized.
Test plan
execution_loggingis optional (not in the top-levelrequiredarray)🤖 Generated with Claude Code