fix(motor test): There was a error popup about functools.partial - #1251
Merged
Conversation
In frontend_tkinter_motor_test.py, the _schedule_ready_reset method was using functools.partial to schedule a delayed callback with tkinter.after(). However, Tkinter's after() method tries to access the __name__ attribute of the callable for internal tracking, and functools.partial objects don't have this attribute, causing the error.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an error in the motor test functionality where using functools.partial with tkinter's after() method caused an AttributeError because functools.partial objects don't have a __name__ attribute that Tkinter expects.
Changes:
- Removed unused
functools.partialimport - Replaced
functools.partialwith a lambda expression in_schedule_ready_resetmethod
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In frontend_tkinter_motor_test.py, the _schedule_ready_reset method was using functools.partial to schedule a delayed callback with tkinter.after(). However, Tkinter's after() method tries to access the name attribute of the callable for internal tracking, and functools.partial objects don't have this attribute, causing the error.