feat(log-analysis): add timestamped parameter history - #1995
Open
nflyernz wants to merge 2 commits into
Open
Conversation
Signed-off-by: nflyernz <319460892+nflyernz@users.noreply.github.com>
Signed-off-by: nflyernz <319460892+nflyernz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description
Adds reusable timestamped parameter-history support to AMC log analysis.
AMC currently reduces
PARMmessages to a single final value per parameter. That is sufficient for log-level analysis, but can give incorrect results when a parameter changes during a log containing multiple flights.This adds:
ParameterHistory.from_log_data(log_data)ParameterHistory.value_at(parameter_name, time_s) -> float | NoneLogAnalysisContext.parametersremains unchanged and continues to expose the final logged value.ArduPilot writes its initial parameter snapshot progressively at log startup. Therefore, the first logged
PARMoccurrence for a parameter is treated as the log-start baseline, even when that record has a later timestamp. Subsequent records take effect at their timestamps.No Plane-specific analysis, landing detection, frontend, or log extraction changes are included.
Checklist
git commit --signoff)Testing
Validation:
40 passed4821 passed, 6 skipped, 4 xfailed, 53 deselected10.00/10git diff --check: passedlog_17.bin: passedpre-commit run --all-filesreached the existing externalmarkdownlint-clinpmEALLOWGITinstallation failure; no source-related pre-commit failure was observed.Checklist
git commit --signoff)Testing
Describe how you tested these changes: