Upgrade pyinstaller - #2016
Open
amilcarlucas wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Upgrades the pinned PyInstaller toolchain versions and removes a Tcl/Tk bundling workaround + corresponding CI assertion used when building the Windows/macOS distributables.
Changes:
- Bump
pyinstallerto6.22.2andpyinstaller-hooks-contribto2026.7for win/mac/linux build dependency groups. - Remove custom Tcl/Tk discovery +
TCL_LIBRARY/TK_LIBRARYenvironment setup from the Windows.specfile. - Remove the CI step that asserted Tcl/Tk data files were present in the built Windows artifact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
windows/ardupilot_methodic_configurator.spec |
Removes explicit Tcl/Tk environment setup previously used to ensure Tk data bundling. |
pyproject.toml |
Updates pinned PyInstaller and hooks-contrib versions for distribution dependency groups. |
.github/workflows/build_windows_macos.yml |
Removes a build-time assertion verifying bundled Tcl/Tk library data presence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
4
to
6
| from PyInstaller.utils.hooks import collect_submodules | ||
| import certifi | ||
| import os |
| throw "PyInstaller did not bundle the Tcl/Tk library data." | ||
| } | ||
| del ardupilot_methodic_configurator.spec | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade pyinstaller and remove an outdated test
Checklist
git commit --signoff)Testing
Describe how you tested these changes: