4.8:32437/copter: document swashplate phase angle available for all types - #7964
Open
Hwurzburg wants to merge 1 commit into
Open
4.8:32437/copter: document swashplate phase angle available for all types#7964Hwurzburg wants to merge 1 commit into
Hwurzburg wants to merge 1 commit into
Conversation
ArduPilot/ardupilot#32437 renamed H_SW_H3_PHANG/H_SW2_H3_PHANG to H_SW_PHANG/H_SW2_PHANG and made phase angle compensation available for every swashplate type, not just H3 Generic. - traditional-helicopter-swashplate-setup.rst: dropped "and phase angle" from the H3 Generic bullet, added a general Phase Angle Compensation section - dual-helicopter.rst: moved the phase angle parameter out of each "only needed if H3 Generic" bullet list into a standalone note (4 configurations x 2 swashplates) - traditional-helicopter-parameter-list.rst: renamed the parameter references and moved them into the general setup lists rather than the H3-only "Custom Swashplate Configuration" section Verified against the actual PR source (AP_MotorsHeli_Swash.cpp) with a second Codex pass, which confirmed every H_SW_TYPE routes through add_servo_angle() and caught that the parameter-list page still had it misplaced in the H3-only section after the first pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArduPilot/ardupilot#32437 renamed H_SW_H3_PHANG/H_SW2_H3_PHANG to H_SW_PHANG/H_SW2_PHANG and made phase angle compensation available for every swashplate type, not just H3 Generic.
Verified against the actual PR source (AP_MotorsHeli_Swash.cpp) with a second Codex pass, which confirmed every H_SW_TYPE routes through add_servo_angle() and caught that the parameter-list page still had it misplaced in the H3-only section after the first pass.