fix: ship Debug and Release libs in Windows package (#1298) - #1301
Merged
Conversation
Install libs to lib/<config>/ on multi-config generators so both runtimes (/MD and /MDd) coexist in the same package. CI now builds both configurations before running cpack.
|
Owner
Author
|
@Hay1tsme - What do you think of this PR? Could you please take a look? |
|
This is just what I was hoping for, thank you! Apologies for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1298.
On multi-config generators (Visual Studio),
cmake --installnow placeslibraries under
lib/Debug/andlib/Release/instead of a sharedlib/directory, so both runtimes (
/MDdand/MD) can coexist in the samepackage.
The CI release workflow gains a dedicated Windows step that builds both
configurations and passes
-C "Debug;Release"to CPack.A graceful fallback with a
WARNINGis emitted when CMake < 3.20 isdetected (generator expressions in
DESTINATIONrequire 3.20).