Upstream#5
Open
IPECTER wants to merge 9 commits into
Open
Conversation
Microsoft renamed it a while ago, so I changed a few things to keep it up to date.
Changed '!mdl.subModules.length > 0' to 'mdl.subModules.length === 0'. The original code had a bug due to JavaScript's operator precedence: the '!' operator binds tighter than '>', so '!mdl.subModules.length' is evaluated first (producing a boolean), then '> 0' compares that boolean to 0, which is always truthy. The fix uses '=== 0' to correctly check if the array is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.