fix(payout): allow wallet registration while payout pipeline is disabled (#954) - #955
Merged
Merged
Conversation
#954) Decouple wallet registration from the execution pipeline so providers can change payout addresses when the runner is deliberately off. Mount challenge/register plus pause/resume whenever hot_wallet_address is set; keep runner/signer/RPC/lease and execution-only admin routes behind payout.enabled=true. Amend SPEC-016 to v0.1.26 and improve Malibu HTTP 404 copy. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…on-only PR Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Co-authored-by: Cursor <cursoragent@cursor.com>
antfleet-ops
approved these changes
Aug 8, 2026
antfleet-ops
left a comment
Collaborator
There was a problem hiding this comment.
Approved: registration-only §3.3 mount while payout.enabled=false closes #954; execution pipeline stays gated; audits cleared to 0 CRITICAL/HIGH/MEDIUM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payout.security.hot_wallet_addressis set, even whenpayout.enabled=false— closes Malibu Change-wallet HTTP 404 (Malibu "Open browser wallet" fails with HTTP 404 — allow payout-address registration while payout pipeline is disabled #954).GET /providers/{id}/payouts) behindpayout.enabled=true.Test plan
go test ./internal/payout/ ./internal/config/go build ./cmd/coordinator/python3 scripts/check_spec_governance.py/gen_spec_index.py --checkpayout.enabled=false, restart, confirm journalpayout registration-only enabledand challenge returns 401 (not 404)SPEC-GOVERNANCE-DECLARATION-BEGIN
{
"schema_version": "spec-pr-governance-v1",
"behavior_change": "yes",
"contract_change": "yes",
"specs": ["SPEC-016"],
"requirements": ["SPEC-016-R002"],
"authority_domains": ["payout-lifecycle"],
"arbitration": ["CODE_BUG", "SPEC_BUG"],
"tests": ["phase4-coordinator/internal/payout/registration_only_test.go"],
"journeys": ["JOURNEY-SPEC-016-PAYOUT-ADDRESS-REGISTRATION"],
"issue": "#954"
}
SPEC-GOVERNANCE-DECLARATION-END