Per-device color calibration with assisted 3D-LUT wizard#294
Open
joaocaparroz wants to merge 1 commit into
Open
Per-device color calibration with assisted 3D-LUT wizard#294joaocaparroz wants to merge 1 commit into
joaocaparroz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-device color calibration with assisted 3D-LUT wizard
Closes #293
Summary
Makes RGB devices from different models look the same by extending per-device calibration into an optional color pipeline, plus an assisted wizard that matches a target device to a reference device by eye.
Motivation
The same logical color renders slightly differently across devices. The existing
DeviceCalibrations(one multiplicativeSimpleColorper device) can only dim each channel — it can't fix non-linear brightness response, the tonality of mixed colors (white matches but purple doesn't), or specific stubborn colors.What's added
DeviceCalibration): per-channel brightnessCalibrationCurve, a 3×3ColorMatrix, an optional non-linear set ofColorSamples baked into a 3D-LUT, plus the existing manual brightness/gamma/gain.CalibrationLookup):curve → matrix → 3D-LUT (trilinear) → manual, resolved once per device update and cached. Applied for all device types — RGB.NET (per sub-device inRgbNetDeviceUpdater) and native (centrally inDefaultDevice).Control_CalibrationWizard): pick a reference + target device; stage 1 matches per-channel brightness, stage 2 fits the matrix from white + primaries + secondaries, stage 3 fixes specific intermediate colors (suggested list + add-your-own). Devices are lit to live test colors over the device-manager pipe (calibrationPreview/calibrationEnd).3D-LUT · N pts · Matrix · Curves · Manual), a before/after hue preview, and a Details panel showing the matrix and the LUT correction points.Backward compatibility
Legacy
DeviceCalibrations(SimpleColor) are migrated into the new model on config load (DeviceConfig.MigrateCalibrations); the new data lives inDeviceColorCalibrations.Scope / limitations
How to test
Screenshots