HYDRA-2274 : more fixes for usd 26.05 unit tests - #461
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Maya-to-Hydra test suite and scene-browser tests to accommodate OpenUSD 26.05 behavior changes by introducing new usd26.05+ baseline sets and adjusting traversal/value formatting to match updated Hydra UI output.
Changes:
- Add
usd26.05+baseline image folders (and documentation) for USDLights, ArnoldLights, and TexturedMode tests. - Update Python snapshot tests to select the correct baseline version based on detected USD version (25.11 vs 26.05+), and adjust viewport setup for textured-mode testing.
- Update
adskHydraSceneBrowsertests to match Hydra UI sorting/top-level behavior (USD 25.11+) and to handleHdPrimOriginSchema::OriginPathvalue formatting in USD 26.05.
Reviewed changes
Copilot reviewed 9 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/lib/mayaUsd/render/mayaToHydra/USDLightsTest/usd26.05+/BASELINES.md |
Documents new USD 26.05+ baseline expectations and rationale. |
test/lib/mayaUsd/render/mayaToHydra/USDLightsTest/usd25.11/domeLight.png |
Baseline image update (binary). |
test/lib/mayaUsd/render/mayaToHydra/TexturedModeTest/usd26.05+/BASELINES.md |
Documents new USD 26.05+ textured-mode baselines and rationale. |
test/lib/mayaUsd/render/mayaToHydra/testUSDLights.py |
Selects 25.11 vs 26.05+ baseline folders and passes imageVersion to snapshots. |
test/lib/mayaUsd/render/mayaToHydra/testTexturedMode.py |
Uses active editor panel, adjusts display appearance, and adds USD 26.05+ gating. |
test/lib/mayaUsd/render/mayaToHydra/testArnoldLights.py |
Selects 25.11 vs 26.05+ baseline folders and passes imageVersion to snapshots. |
test/lib/mayaUsd/render/mayaToHydra/ArnoldLightsTest/usd26.05+/BASELINES.md |
Documents new USD 26.05+ ArnoldLights baselines and rationale. |
test/lib/mayaUsd/render/mayaToHydra/ArnoldLightsTest/usd25.11/allLights.png |
Baseline image update (binary). |
lib/mayaHydra/mayaPlugin/renderOverride.cpp |
Tracks initial textured state when creating the prune-textures scene index. |
lib/adskHydraSceneBrowser/test/adskHydraSceneBrowserTestFixture.h |
Adjusts test helper signature and includes <stack>. |
lib/adskHydraSceneBrowser/test/adskHydraSceneBrowserTestFixture.cpp |
Matches Hydra UI ordering and fixes value formatting for OriginPath on USD 26.05. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+76
to
+80
| self.assertSnapshotClose( | ||
| "untextured.png", | ||
| self.IMAGE_DIFF_FAIL_THRESHOLD, | ||
| self.IMAGE_DIFF_FAIL_PERCENT | ||
| self.IMAGE_DIFF_FAIL_PERCENT, | ||
| imageVersion |
Comment on lines
+135
to
+144
| int prevCount = -1; | ||
| int currCount = 0; | ||
| while (currCount != prevCount) { | ||
| prevCount = currCount; | ||
| treeWidget->expandAll(); | ||
| // Process queued events: fires deferred QTimer::singleShot expansions | ||
| // and avoids crashes with since-deleted items (see original comment). | ||
| QApplication::processEvents(QEventLoop::ProcessEventsFlag::EventLoopExec); | ||
| currCount = CountTreeItems(treeWidget); | ||
| } |
| const bool pruneTextures = !(drawContext.getDisplayStyle() & MHWRender::MFrameContext::kTextured); | ||
| _lastFilteringSceneIndexBeforeCustomFiltering = _pruneTexturesSceneIndex = | ||
| Fvp::PruneTexturesSceneIndex::New(_lastFilteringSceneIndexBeforeCustomFiltering, pruneTextures); | ||
| _currentlyTextured = !pruneTextures; |
Collaborator
There was a problem hiding this comment.
Nice, I had this fix locally for materialX testing. Thanks for pushing this
…ailure Co-authored-by: Cursor <cursoragent@cursor.com>
benyoon-adsk
previously approved these changes
Jun 25, 2026
benyoon-adsk
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.