HYDRA-2383 : Add unit test for HdArnold custom nodes - #462
Merged
lilike-adsk merged 3 commits intoJul 9, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Maya-to-Hydra unit test suite that validates HdArnold’s custom-node translation (mtoaSIP) behavior when Arnold is the active Hydra renderer, and wires the new tests into the existing C++/Python test harness and build/test configuration.
Changes:
- Added a Python driver test that activates the Arnold Hydra renderer, creates Arnold plugin nodes, and dispatches into C++ gtests via
mayaHydraCppTest. - Added a C++ gtest suite that verifies translated prim types and key attribute mappings for
aiPhotometricLight,aiStandIn, andaiVolume. - Updated test CMake wiring and test environment setup to include the new test sources/scripts and to register MtoA USD plugins via the USD plugin path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.py | Python test driver that switches to Arnold Hydra override, creates test nodes, and invokes the C++ checks. |
| test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.cpp | New gtests validating mtoaSIP custom-node translation results in the Hydra scene index. |
| test/lib/mayaUsd/render/mayaToHydra/cpp/CMakeLists.txt | Adds the new C++ test source to the cpp test target. |
| test/lib/mayaUsd/render/mayaToHydra/CMakeLists.txt | Registers the new Python test script in the interactive test script list. |
| cmake/test.cmake | Extends test environment setup to append MtoA USD bundle path to the USD plugin path for test runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lanierd-adsk
reviewed
Jul 3, 2026
lanierd-adsk
left a comment
lanierd-adsk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this, only one comment.
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // C++ GTest suite for the HdArnoldMtoaSceneIndexPlugin (mtoaSIP). |
Collaborator
There was a problem hiding this comment.
I would add a comment to say that mtoaSIP is scene index plugin, it's not obvious
lanierd-adsk
previously approved these changes
Jul 3, 2026
benyoon-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit test for HdArnold custom nodes implementation from https://github.com/Autodesk/arnold-usd/pull/2653/changes.
aiSkyDomeLight and aiAreaLight are not tested because they have existing maya-hydra adapters (aiSkydomeLightAdapter / aiAreaLightAdapter) that produce domeLight / rectLight prims directly, so they don't go through the mayaCustomDagNode / mtoaSIP paths.