-
Notifications
You must be signed in to change notification settings - Fork 14
Added HdArnold v2 render settings tests. #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1565,6 +1565,12 @@ void MayaHydraSceneIndex::InsertDag(const MDagPath& dag) | |
| return; | ||
| } | ||
|
|
||
| // Cameras can be invisible and still be renderable, so adapter creation | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tests with Hydra v2 render settings were failing as Maya cameras were not being translated into the Hydra scene. For Hydra v1 render settings we translate using camera parameters and do not check the visibility status of cameras. |
||
| // must occur before the visibility check. | ||
| if (CreateCameraAdapter(dag)) { | ||
| return; | ||
| } | ||
|
|
||
| // In batch mode (useMeshAdapter), MItDag visits every DAG node including | ||
| // LOD meshes and corrective blend-shape targets that VP2 never makes render | ||
| // items for. Skip shapes that are not visible so that only the intended | ||
|
|
@@ -1585,14 +1591,13 @@ void MayaHydraSceneIndex::InsertDag(const MDagPath& dag) | |
| return; | ||
| } | ||
|
|
||
| // Custom lights don't have MFn::kLight. | ||
| // Invisible lights don't contribute to the scene, so light adapter | ||
| // creation after the visibility check above is correct. Custom lights | ||
| // don't have MFn::kLight. | ||
| if (CreateLightAdapter(dag)) { | ||
| return; | ||
| } | ||
|
|
||
| if (CreateCameraAdapter(dag)) { | ||
| return; | ||
| } | ||
| // We are inserting a single prim and | ||
| // instancer for every instanced mesh. | ||
| if (dag.isInstanced() && dag.instanceNumber() > 0) { | ||
|
|
||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make sure that InsertDag is not part of the public interface of this class. |
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Run through the HdArnold tests again, using Hydra v2 render settings in this loop. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,23 @@ foreach(scene ${ARNOLD_RENDER_SCENES}) | |
| ) | ||
| endforeach() | ||
|
|
||
| foreach(scene ${ARNOLD_RENDER_SCENES}) | ||
| cmake_path(GET scene STEM sceneFileNameNoExt) | ||
| set(render_dir ${CMAKE_BINARY_DIR}/test/Temporary/${sceneFileNameNoExt}_v2_rs/projects/default/images) | ||
| mayaHydra_add_cmd_line_render_test(${scene} | ||
| COPY_SCENE | ||
| RENDERER HdArnoldRendererPlugin | ||
| RENDERED_IMAGE_SUBDIR projects/default/images | ||
| RENDERED_IMAGE_NAME ${sceneFileNameNoExt}_v2_rs | ||
| RENDERER_ARGS "-x 160 -y 120 -rd \"${render_dir}\" -im ${sceneFileNameNoExt}_v2_rs" | ||
| TEST_NAME_SUFFIX v2_rs | ||
| ENV | ||
| "MAYA_HYDRA_HD_ARNOLD_HYDRA_V2_RENDER_SETTINGS=1" | ||
| "USDIMAGINGGL_ENGINE_ENABLE_SCENE_INDEX=1" | ||
|
Comment on lines
+86
to
+87
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awkwardly, two environment variables are needed to enable Hydra v2 render settings in Arnold. This is being discussed with the Arnold team. |
||
| "TF_DEBUG=MAYAHYDRAPLUGIN_BATCHRENDER_RENDER_SETTINGS" | ||
| ) | ||
| endforeach() | ||
|
|
||
| mayaHydra_add_cmd_line_render_test(renderSettings/stormResolution.ma | ||
| COPY_SCENE | ||
| RENDERER HdStormRendererPlugin | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the capability to add a suffix to create a test with a different label from an existing scene. This is used in this branch to run tests with Hydra v1 render settings as well as Hydra v2 render settings.