Render command line Hydra scene dump functionality, with tests. - #466
Conversation
There was a problem hiding this comment.
Moved to fvpSceneIndexUtils.h, to be used in non-test code.
There was a problem hiding this comment.
Moved to fvpSceneIndexUtils.cpp, to be used in non-test code.
There was a problem hiding this comment.
Moved from testUtils.h, to be used in non-test code.
There was a problem hiding this comment.
Moved from testUtils.cpp, to be used in non-test code.
There was a problem hiding this comment.
Added Hydra scene dump capability for all renderers.
There was a problem hiding this comment.
Expected dump file for test.
There was a problem hiding this comment.
Expected dump file for test.
|
|
||
| _engine.Execute(_renderIndex, &tasks); | ||
|
|
||
| dumpHydraScene(_renderIndex); |
There was a problem hiding this comment.
Optionally dump the Hydra scene, for debugging.
There was a problem hiding this comment.
Add two Hydra scene dump tests, one for the terminal scene index, the other for the Maya Hydra scene index (which translates Maya data to Hydra).
There was a problem hiding this comment.
Instead of using platform-native fc on Windows and diff on UNIX, AI suggested (and wrote) this Python comparison script, which is more robust to line ending differences, and turned out to be very handy to filter out object address differences (which are encoded in some of the Hydra prim names we generate). Since these may differ from machine to machine and run to run, the exact object hexadecimal address must not be considered in the file difference.
There was a problem hiding this comment.
Could this info be included in the comments?
There was a problem hiding this comment.
See comments in CMakeLists.txt.
|
|
||
| def _ensureStringAttr(attrName, value): | ||
| exists = cmds.attributeQuery(attrName, node=_NODE, exists=True) | ||
| if not value and not exists: |
There was a problem hiding this comment.
Small nit, the conditions not exists seem redundant, would this be better?
if not exists:
if not value:
return
cmds.addAttr(_NODE, longName=attrName, dataType='string')
cmds.setAttr('%s.%s' % (_NODE, attrName), value, type='string')
…in traversal order." This reverts commit 0b07d02.
ppt-adsk
added
the
ready-for-merge
3 participants
No description provided.