HYDRA-2347 : Add Arnold custom attributes on Maya node unit test - #470
Merged
debloip-adsk merged 2 commits intoJul 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Arnold-focused test pair (Python driver + C++ GTest) to validate translation of Arnold custom attributes on native Maya nodes through the Arnold scene index chain, and wires the new test into the existing mayaToHydra C++ test target / interactive test script list.
Changes:
- Add
testArnoldCustomAttributesMayaNodes.py/.cppto exercise Arnoldai*attributes on mesh/camera/lights and validate resulting Hydra primvars / light schema values. - Register the new C++ test source and Python script in the relevant CMake test lists.
- Rename the existing
testArnoldCustomNodes.cppGTest suite name (currently breaks the Python harness mapping).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.py | Removes dead/commented teardown snippet (no functional change). |
| test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.cpp | Renames GTest suite identifiers (currently mismatched with Python driver). |
| test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.py | New Python driver that sets Arnold renderer, creates nodes, and dispatches into C++ tests. |
| test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp | New C++ GTests validating Arnold attr → primvar/light-schema translation. |
| test/lib/mayaUsd/render/mayaToHydra/cpp/CMakeLists.txt | Adds new C++ test source to the cpp test target. |
| test/lib/mayaUsd/render/mayaToHydra/CMakeLists.txt | Adds new Python script to the interactive test scripts list (Maya > 2026). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
debloip-adsk
deleted the
yoonb1/HYDRA-2347/add-maya-node-custom-attr-test
branch
July 13, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of tested Arnold custom attributes on Maya nodes: