Skip to content

HYDRA-2347 : Add Arnold custom attributes on Maya node unit test - #470

Merged
debloip-adsk merged 2 commits into
devfrom
yoonb1/HYDRA-2347/add-maya-node-custom-attr-test
Jul 13, 2026
Merged

HYDRA-2347 : Add Arnold custom attributes on Maya node unit test#470
debloip-adsk merged 2 commits into
devfrom
yoonb1/HYDRA-2347/add-maya-node-custom-attr-test

Conversation

@benyoon-adsk

Copy link
Copy Markdown
Collaborator

List of tested Arnold custom attributes on Maya nodes:

  • Mesh
    • aiSubdivType, aiDispHeight, aiOpaque, aiMatte, aiSelfShadows
  • Camera
    • aiExposure, aiFocusDistance
  • Lights
    • directionalLight
      • aiAngle, aiCastVolumetricShadows, aiColorTemperature, aiExposure
    • areaLight
      • aiResolution, aiSpread, aiRoundness

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Arnold-focused test pair (Python driver + C++ GTest) to validate translation of Arnold custom attributes on native Maya nodes through the Arnold scene index chain, and wires the new test into the existing mayaToHydra C++ test target / interactive test script list.

Changes:

  • Add testArnoldCustomAttributesMayaNodes.py/.cpp to exercise Arnold ai* attributes on mesh/camera/lights and validate resulting Hydra primvars / light schema values.
  • Register the new C++ test source and Python script in the relevant CMake test lists.
  • Rename the existing testArnoldCustomNodes.cpp GTest suite name (currently breaks the Python harness mapping).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.py Removes dead/commented teardown snippet (no functional change).
test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.cpp Renames GTest suite identifiers (currently mismatched with Python driver).
test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.py New Python driver that sets Arnold renderer, creates nodes, and dispatches into C++ tests.
test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp New C++ GTests validating Arnold attr → primvar/light-schema translation.
test/lib/mayaUsd/render/mayaToHydra/cpp/CMakeLists.txt Adds new C++ test source to the cpp test target.
test/lib/mayaUsd/render/mayaToHydra/CMakeLists.txt Adds new Python script to the interactive test scripts list (Maya > 2026).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.cpp
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.cpp
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomNodes.cpp
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp Outdated
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp Outdated
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp Outdated
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp Outdated
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp Outdated
Comment thread test/lib/mayaUsd/render/mayaToHydra/cpp/testArnoldCustomAttributesMayaNodes.cpp Outdated

@ppt-adsk ppt-adsk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@benyoon-adsk benyoon-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jul 13, 2026
@debloip-adsk
debloip-adsk merged commit 0e125a3 into dev Jul 13, 2026
11 checks passed
@debloip-adsk
debloip-adsk deleted the yoonb1/HYDRA-2347/add-maya-node-custom-attr-test branch July 13, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge Development process is finished, PR is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants