Add warning when marquee selecting with GeomSubset picking and no GeomSubsets are found - #475
Merged
Merged
Conversation
…mSubsets are found
debloip-adsk
commented
Jul 28, 2026
Comment on lines
+2275
to
+2291
| // If a marquee selection is done with GeomSubset picking enabled, and there are more than 1 pick hits, | ||
| // only GeomSubsets will be considered for picking. If the user forgets they have GeomSubset picking on, | ||
| // this can lead to situations where they do a marquee select on USD data and nothing is selected. | ||
| // Warn the user about this so they are aware and potentially adjust their GeomSubset selection mode. | ||
| if (geomSubsetsPickMode == GeomSubsetsPickModeTokens->Faces | ||
| && !singlePick | ||
| && !pointSnappingActive | ||
| && !outHits.empty() | ||
| && _ufeSn && _ufeSn->size() == ufeSnSizeBefore | ||
| && selectionList.length() == mayaSnLengthBefore) | ||
| { | ||
| MGlobal::displayWarning( | ||
| "Marquee selection found pick hits but no selectable data. Note that for USD data, marquee selections with " | ||
| "GeomSubset picking enabled only select GeomSubsets and not the base geometry prims. " | ||
| "Please adjust the USD GeomSubset selection mode if necessary."); | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I tried to explain this as best I could, let me know if anything is unclear :)
benyoon-adsk
approved these changes
Jul 29, 2026
debloip-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been a source of confusion a few times before, this should help avoid future instances.