LOOKDEVX-4775 - Implement dstParentPath duplicate option of BatchOpsHandler. - #4296
Merged
Merged
Conversation
frohnej-adsk
commented
Aug 12, 2025
| return nullptr; | ||
| } | ||
|
|
||
| return Ufe::Hierarchy::createItem(it->second->path()); |
Collaborator
Author
There was a problem hiding this comment.
Recreate the item in case it went stale.
I tried changing _duplicatedItemsMap to just store paths to prevent items from going stale in the first place, but that caused issues with the clipboard. If this command is used to duplicate |stage1|stageShape1,/mtl/add1 to the clipboard, the UFE path of the duplicated item will just be /add1 -- it's at the root of the clipboard stage.
Ufe::Hierarchy::createItem() is not able to create an item from /add1, so the clipboard relies on the actual item being stored and returned by UsdUndoDuplicateSelectionCommand::getDuplicatedItemsMap().
seando-adsk
reviewed
Aug 12, 2025
|
|
||
| #include "UsdUndoDuplicateSelectionCommand.h" | ||
|
|
||
| #include "ufe/hierarchy.h" |
Collaborator
There was a problem hiding this comment.
Ufe headers come after the block of headers.
seando-adsk
previously approved these changes
Aug 12, 2025
JGamache-autodesk
previously approved these changes
Aug 12, 2025
frohnej-adsk
dismissed stale reviews from JGamache-autodesk and seando-adsk
via
August 13, 2025 11:09
aa95fef
seando-adsk
approved these changes
Aug 18, 2025
frohnej-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a new option of
Ufe::BatchOpsHandler::duplicateSelectionCmd()to duplicate items to the specified location.