EMSUSD-3774 - Investigate shader node metadata difference causing test failure - #4647
Merged
seando-adsk merged 1 commit intoJun 12, 2026
Merged
Conversation
…t failure
* Starting in OpenUSD 26.03, Pixar added strongly typed metadata via SdrShaderPropertyMetadata.
For __SDR__defaultinput, the registered type is bool, not string:
{SdrPropertyMetadata->DefaultInput, _LegacyStringToBool}
frohnej-adsk
approved these changes
Jun 12, 2026
Comment on lines
+196
to
+199
| # Starting in OpenUSD 26.03, Pixar added strongly typed metadata via SdrShaderPropertyMetadata. | ||
| # For __SDR__defaultinput, the registered type is bool, not string: | ||
| # {SdrPropertyMetadata->DefaultInput, _LegacyStringToBool} | ||
| # Thus: "in1" is not "0" / "false" / "f", so it becomes true. |
Collaborator
There was a problem hiding this comment.
Thank you for the explanation! I'm still very confused why USD makes it a boolean. I wonder if it's intentional or a bug in USD...
Either way, if we notice any issues being caused by this, we can come back and see if there is a way to access the raw string. But perhaps the defaultinput metadata isn't even used.
Collaborator
Author
seando-adsk
added
the
ready-for-merge
seando-adsk
deleted the
donnels/EMSUSD-3774/fix_failing_testShaderNodeDef
branch
June 12, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EMSUSD-3774 - Investigate shader node metadata difference causing test failure