EMSUSD-2803 fix import of USD with an alembic reference - #4683
Merged
Conversation
pierrebai-adsk
added
bug
- Changed all calls to USD in `meshReadUtils.cpp` to pass `UsdTimeCode::EarliestTime()`. - Added an import unit test that failed without the fix and now passes.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2803/alembic-import-no-uv
branch
from
July 28, 2026 17:00
2bf642d to
a21995c
Compare
barbalt
approved these changes
Jul 28, 2026
barbalt
left a comment
barbalt
left a comment
Collaborator
There was a problem hiding this comment.
The changes Looks good. I do have a concern that might be out of the scope of those changes. The user can specify the animation range in which they want to import a stage; this range can differ from the stage's "earliest time"
Collaborator
Author
|
Using earliest time is done elsewhere in the code base. We can revisit if we get an bug report about it, I suppose. |
pierrebai-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meshReadUtils.cppto passUsdTimeCode::EarliestTime().