Skip to content

Fix various EF dialog issues. - #4688

Merged
antonkhelou merged 7 commits into
devfrom
deboisj/EMSUSD-3936-ef_window_behind
Aug 4, 2026
Merged

Fix various EF dialog issues.#4688
antonkhelou merged 7 commits into
devfrom
deboisj/EMSUSD-3936-ef_window_behind

Conversation

@deboisj

@deboisj deboisj commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Adresses several small issues with the Usd Edit Forward configuration dialog.

https://autodesk.atlassian.net/browse/EMSUSD-3907 menu / windows titles

  • Fix the menu entry and window title strings to match design.

https://autodesk.atlassian.net/browse/EMSUSD-3936 windows goes behind maya on macOs

  • Fixed an issue where on OSX losing focus on the Edit Forward configuration dialog would push it "behind" the maya application.

https://autodesk.atlassian.net/browse/EMSUSD-3940 position/size lost on toggle open/close

  • Fixed an issue where the edit forward dialog position and size configured by users was not preserved withing a maya session.

https://autodesk.atlassian.net/browse/EMSUSD-3904

  • Fixed EF config button tooltips to match design

deboisj and others added 4 commits August 3, 2026 13:14
…maya's main window

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Give the dialog an object name, which Maya uses as the key for its saved
window preference. Replace the unconditional resize() in the constructor
with a sizeHint() override so the default size no longer overwrites the
geometry Maya restores. Skip show() when the dialog is already visible,
since showing a saveWindowPref window re-applies its stored position and
moved an already-open dialog back to where it was last saved.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

// Tell Maya to treat this as a Maya-managed window. This is the same
// mechanism Maya uses internally to keep its own dialogs from going behind
// the main window. This should not be combined with other flags.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same fix as in AR 3aa943c

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This should not be combined with other flags." what does this mean?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Per Maya dev guidance these two calls should be applied alone, without combining with any other Qt window flags."

Is what that other commit wrote.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AramAzhari-adsk Do you know specifics?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply as I was OoO. For the record, we are referring to the line after: WindowFlags

This should not be combined
            // with other flags.
            g_assetResolverDialog->setWindowFlags(Qt::Window);

I hope that clears it up.

{
auto* ss = &_sessionState;
if (_editForwardDialog) {
if (!_editForwardDialog) {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are also bascially the same as what was done in AR 3aa943c

{
setAttribute(Qt::WA_DeleteOnClose);
setWindowTitle(title);
resize(

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop forcing the size everytime. Via size hint and with the other changes below, keeps the user size

@deboisj deboisj self-assigned this Aug 3, 2026
@deboisj deboisj added the workflows Related to in-context workflows label Aug 3, 2026
@deboisj deboisj assigned deboisj and unassigned deboisj Aug 3, 2026
Clarified comments regarding window flags usage in Maya.
@deboisj deboisj assigned deboisj and unassigned deboisj Aug 4, 2026
@deboisj deboisj assigned deboisj and unassigned deboisj Aug 4, 2026
@deboisj deboisj added the ready-for-merge Development process is finished, PR is ready for merge label Aug 4, 2026
@antonkhelou
antonkhelou merged commit 1950e33 into dev Aug 4, 2026
12 checks passed
@antonkhelou
antonkhelou deleted the deboisj/EMSUSD-3936-ef_window_behind branch August 4, 2026 16:51
@seando-adsk seando-adsk added shared_components Shared Components (Max / Maya) and removed workflows Related to in-context workflows labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge Development process is finished, PR is ready for merge shared_components Shared Components (Max / Maya)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants