EMSUSD-3530 save proxy shape of component as component - #4690
Merged
Conversation
- Detect that a proxy shape is a component and ask the component creator to save it. Added unit tests: - Added unit tests to verify that the Maya save command saves components with variants correctly and the data is correct when reloaded. - The test needs to reload the stage because the saving bug would manifest itself only when fully reloading the stage, like when opening the scene in a fresh Maya session.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-3530/multi-variants-maya-save
branch
from
August 4, 2026 19:43
57498d9 to
5b77407
Compare
antonkhelou
reviewed
Aug 5, 2026
antonkhelou
reviewed
Aug 5, 2026
antonkhelou
reviewed
Aug 5, 2026
antonkhelou
reviewed
Aug 5, 2026
Comment on lines
+1151
to
+1155
| if (fn.isFromReferencedFile()) | ||
| continue; | ||
|
|
||
| if (!LayerDatabase::instance().supportedNodeType(fn.typeId())) | ||
| continue; |
Collaborator
There was a problem hiding this comment.
Did you unbundle the condition for clarity?
Collaborator
Author
There was a problem hiding this comment.
Yeah, the code changed a bit during dev and had more if, so I reduced the level of nested indent. I do prefer fewer indent and early exit, personally, so I left the change in.
antonkhelou
reviewed
Aug 5, 2026
antonkhelou
approved these changes
Aug 5, 2026
pierrebai-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EMSUSD-3530 - save proxy shape of component as component
Description
Bug fix:
Added unit tests: