Skip to content

EMSUSD-2536 USD Animation Options are lost when deselected and collapsed - #4694

Merged
seando-adsk merged 1 commit into
devfrom
EMSUSD-2536-animation-options-ui-are-lost
Aug 10, 2026
Merged

EMSUSD-2536 USD Animation Options are lost when deselected and collapsed#4694
seando-adsk merged 1 commit into
devfrom
EMSUSD-2536-animation-options-ui-are-lost

Conversation

@barbalt

@barbalt barbalt commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Fix a visual bug when disabling the animation options.

@barbalt barbalt self-assigned this Aug 7, 2026

@pierrebai-adsk pierrebai-adsk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion how to fix it differently.

Although, IDK why we were hiding all the UI...

int $collapse = stringArrayContains("animation", $collapsedSections) ? true : false;
frameLayout -label `getMayaUsdString("kExportFrameAnimationLbl")` -collapsable true -collapse $collapse
-expandCommand("mayaUsdTranslatorExport_AnimationFrameLayoutExpandCB") animationFrameLayout;
frameLayout -label `getMayaUsdString("kExportFrameAnimationLbl")` -collapsable true -collapse $collapse animationFrameLayout;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the behavior I think another way to fix would be to set the visibility of the column layout when toggling the checkbox?

IOW, have a -changeCommand on the animationCheckBox that would call the mayaUsdTranslatorExport_AnimationFrameLayoutExpandCB

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, call tha CB when initially creating / filling the UI with values. IDK if when setting value if the CB gets called. Just test it by hand in Maya once the changes are done, maybe you don't need to explicitly call the CB when filling the values, maybe the CB is also called then, but I'm not sure.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there is already a CB for the check-box. Just need to toggle visibility too in that CB. (mayaUsdTranslatorExport_AnimationCB)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...but honestly, liek I initally said, IDK why we were hiding the UI?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not doing that for materials, and other sections. 🤷

@pierrebai-adsk
pierrebai-adsk self-requested a review August 7, 2026 18:57

@pierrebai-adsk pierrebai-adsk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decied that removing the weird behavior is probably right!

@barbalt barbalt added the ready-for-merge Development process is finished, PR is ready for merge label Aug 7, 2026
@seando-adsk seando-adsk added the import-export Related to Import and/or Export label Aug 10, 2026
@seando-adsk
seando-adsk merged commit 1f13242 into dev Aug 10, 2026
12 checks passed
@seando-adsk
seando-adsk deleted the EMSUSD-2536-animation-options-ui-are-lost branch August 10, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants