EMSUSD-4059 rename active render description prim property. - #4701
Merged
Conversation
ppt-adsk
previously approved these changes
Aug 19, 2026
deboisj
added
shared_components
seando-adsk
requested changes
Aug 19, 2026
|
|
||
| import mayaUsd.lib as mayaUsdLib | ||
| from mayaUsd.lib import UsdDefaultRenderSettings | ||
| from mayaUsd.lib import UsdDefaultRenderDescription |
Collaborator
There was a problem hiding this comment.
Here if you wanted to be lazier you could have imported the UsdDefaultRenderDescription as UsdDefaultRenderSettings
| AdskUsdRenderSetup::HostStage hostStage; | ||
| hostStage.stage = defaultStage; | ||
| hostStage.displayName = kUSDRenderSettingsNodeName; | ||
| hostStage.displayName = tr("Maya Settings").toStdString(); |
Collaborator
There was a problem hiding this comment.
Why is this now "Maya Settings"?
Comment on lines
+37
to
+40
| int MayaRenderSetupHost::dpiScaled(int logicalPixels) const | ||
| { | ||
| return MQtUtil::dpiScale(logicalPixels); | ||
| } |
Collaborator
There was a problem hiding this comment.
We shouldn't really sneak in other changes - this isn't part of renaming. I also have a change to make for a new method on the host. Maybe we put those two together in separate PR.
Collaborator
Author
There was a problem hiding this comment.
Bah - not really snuck in if its in the PR description :) - thought it was small enough.
But alright - so you mean you would make this change at the same time as yours?
deboisj
removed
the
ready-for-merge
deboisj
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.