Skip to content

Quality presets and recommended preset #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itspvty wants to merge 5 commits into from
Closed

Quality presets and recommended preset #1158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef849bf
Graphics presets and auto selection
itspvty Jun 24, 2025
257e87a
Merge branch 'dev' into aries/1781/quality-presets
itspvty Jul 17, 2025
8a7236b
fix: postc
itspvty Jul 17, 2025
0f50dd9
Merge branch 'dev' into aries/1781/quality-presets
Dhruv-0-Arora Jul 18, 2025
b86202e
Merge branch 'dev' into aries/1781/quality-presets
itspvty Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fission/src/Synthesis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ import WPILibConnectionStatus from "./ui/components/WPILibConnectionStatus.tsx"
import AutoTestPanel from "./ui/panels/simulation/AutoTestPanel.tsx"
import GraphicsSettings from "./ui/panels/GraphicsSettingsPanel.tsx"
import MainMenuModal from "@/modals/MainMenuModal"
import { applyInitialGraphicsSettings } from "./ui/panels/GraphicsSettingsPanel"

function Synthesis() {
const { openModal, closeModal, getActiveModalElement, registerModal } = useModalManager(initialModals)
Expand Down Expand Up @@ -96,6 +97,8 @@ function Synthesis() {
startSingleplayerCallback={() => {
World.InitWorld()

applyInitialGraphicsSettings()

Comment on lines +105 to +106

@Dhruv-0-Arora Dhruv-0-Arora Jul 18, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a huge fan of calling a function from a Panel in Synthesis.tsx. If anything, this function should be in a helper .ts file, not .tsx

if (!PreferencesSystem.getGlobalPreference<boolean>("ReportAnalytics") && !import.meta.env.DEV) {
setConsentPopupDisable(false)
}
Expand Down
2 changes: 2 additions & 0 deletions fission/src/systems/preferences/PreferenceTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export type GlobalPreference =
| "SimAutoReconnect"
| "MuteAllSound"
| "SFXVolume"
| "GraphicsOptimizationApplied"

export const RobotPreferencesKey: string = "Robots"
export const FieldPreferencesKey: string = "Fields"
Expand All @@ -40,6 +41,7 @@ export const DefaultGlobalPreferences: { [key: string]: unknown } = {
SimAutoReconnect: false,
MuteAllSound: false,
SFXVolume: 25,
GraphicsOptimizationApplied: false,
}

export type GraphicsPreferences = {
Expand Down
Loading