This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Reduce the props passed in for the image#117
Open
ingeniumed wants to merge 1 commit into
Open
Conversation
alecgeatches
reviewed
Nov 2, 2023
| return ( | ||
| <NextImage | ||
| loader={loader} | ||
| {...imageProps} |
Contributor
There was a problem hiding this comment.
@ingeniumed Minor, but I noticed that we use the NextImage-specific property fill here on line 45:
vip-go-nextjs-skeleton/pages/media/index.tsx
Lines 42 to 47 in 6620e2a
which will get dropped by the changes. Is there a way to change things so Image still properly passes inner properties to NextImage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the way the image props are built results in extra properties being set for the NextImage and the img. This results in warnings being published of unrecognized properties being set. So, this PR sets just the ones that should be necessary instead.
At the moment, that's just alt and src. Happy to add more if need be.